This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
RE: [Patch, AArch64] Implement SIMD Absolute Difference Instructions
- From: "James Greenhalgh" <james dot greenhalgh at arm dot com>
- To: "'Hurugalawadi, Naveen'" <Naveen dot Hurugalawadi at caviumnetworks dot com>, "Marcus Shawcroft" <Marcus dot Shawcroft at arm dot com>
- Cc: <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 1 Mar 2013 13:51:42 -0000
- Subject: RE: [Patch, AArch64] Implement SIMD Absolute Difference Instructions
- References: <F3068DEED1A463459E0887A091B154933A477A@BY2PRD0710MB364.namprd07.prod.outlook.com>,<512CD366.1000302@arm.com> <F3068DEED1A463459E0887A091B154933DE9ED@BY2PRD0710MB364.namprd07.prod.outlook.com>,<512DD9AA.501@arm.com> <F3068DEED1A463459E0887A091B154933DEA37@BY2PRD0710MB364.namprd07.prod.outlook.com>,<512DE6C5.9000202@arm.com> <F3068DEED1A463459E0887A091B154933DEA4B@BY2PRD0710MB364.namprd07.prod.outlook.com>
> >> The use of TAB there is fine. The issue is that you have trail
> white
> >> space at the end of the line, which is still present in the latest
> patch.
>
> Sorry. I confused it with spaces at the start of pattern instead of
> trailing space. I have modified it as per your suggestion.
> Please review the modified patch.
Hi Naveen,
It looks like you didn't quite catch all of them:
> +#define DEF3a(fname, type, op) \
> + void fname##_##type (pR##type a, \
> + pR##type b, \
> + pR##type c) \
> + { \
> + int i; \
> + for (i = 0; i < 16; i++) \<!tab!>
> + a[i] = op (b[i] - c[i]); \
> + }
This one introduces a problem for the testsuite as whitespace between
a \ and the newline is an error on some compilers and a warning on GCC.
There is a script at contrib/check_GNU_style.sh which is helpful
for catching bugs like this.
Thanks,
James Greenhalgh