This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: RFC: add some static probes to libstdc++


On 27/02/2013 21:52, Tom Tromey wrote:

> I'm posting this now to get reactions to the probe before cleaning up
> the corresponding gdb patches for submission.  I've built it both with
> and without sys/sdt.h, but I haven't yet run the test suite.

  How did it build in the without sys/sdt.h case?

> +#ifdef HAVE_SYS_SDT_H
> +#include <sys/sdt.h>
> +/* We only want to use stap probes starting with v3.  Earlier versions
> +   added too much startup cost.  */
> +#if defined (STAP_PROBE2) && _SDT_NOTE_TYPE >= 3
> +#define PROBE2(name, arg1, arg2) STAP_PROBE2 (libstdcxx, name, arg1, arg2)
> +#else
> +#define PROBE2(name, arg1, arg2)
> +#endif
> +#endif
> +

  Without HAVE_SYS_SDT_H, there's no definition of PROBE2 at all, but you use
it unconditionally in eh_{catch,throw}.cc.  Am I missing something?

    cheers,
      DaveK


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]