This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [google gcc-4_7] new module grouping method (issue 7393058)
- From: xur at google dot com
- To: davidxl at google dot com, tejohnson at google dot com, miles at gnu dot org
- Cc: gcc-patches at gcc dot gnu dot org, reply at codereview-hr dot appspotmail dot com
- Date: Wed, 27 Feb 2013 00:57:05 +0000
- Subject: Re: [google gcc-4_7] new module grouping method (issue 7393058)
- Reply-to: xur at google dot com, davidxl at google dot com, tejohnson at google dot com, miles at gnu dot org, gcc-patches at gcc dot gnu dot org, reply at codereview-hr dot appspotmail dot com
https://codereview.appspot.com/7393058/diff/8001/libgcc/dyn-ipa.c
File libgcc/dyn-ipa.c (right):
https://codereview.appspot.com/7393058/diff/8001/libgcc/dyn-ipa.c#newcode1212
libgcc/dyn-ipa.c:1212: mod_id = get_module_id_from_func_glob_uid
(node->guid) - 1;
Send the wrong patch.
Actually. This should be
mod_id = get_module_id_from_func_glob_uid (node->guid);
On 2013/02/27 00:40:31, davidxl wrote:
Change var name from mod_id to mod_idx
https://codereview.appspot.com/7393058/diff/8001/libgcc/dyn-ipa.c#newcode1232
libgcc/dyn-ipa.c:1232: callee_mod_id
Same as above. -1 should be removed.
On 2013/02/27 00:40:31, davidxl wrote:
--> callee_mod_idx
https://codereview.appspot.com/7393058/diff/8001/libgcc/dyn-ipa.c#newcode1250
libgcc/dyn-ipa.c:1250: = get_module_info (callee_mod_id);
This is ok.
On 2013/02/27 00:40:31, davidxl wrote:
Should be get_module_info (callee_mod_idx + 1).
You should carefully check to make sure NO interfaces takes idx as
parameters,
and no interface returns idx.
https://codereview.appspot.com/7393058/diff/8001/libgcc/dyn-ipa.c#newcode2276
libgcc/dyn-ipa.c:2276: /* Dumper function for NODE. M is the module id
and F is the function id. */
On 2013/02/27 00:40:31, davidxl wrote:
M is module_ident -1
Done.
https://codereview.appspot.com/7393058/