This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch, AArch64] Implement SIMD Absolute Difference Instructions


Hi Naveen,

Please accept my apologies for the delay in responding to your patch.

On 30/01/13 05:46, Hurugalawadi, Naveen wrote:


+(define_insn "abd<mode>_3"
+  [(set (match_operand:VDQ_BHSI 0 "register_operand" "=w")
+	(abs:VDQ_BHSI (minus:VDQ_BHSI

Please drop the trailing white space, here and on the following patterns.


--- gcc/testsuite/gcc.target/aarch64/vect-fp.x	2013-01-24 20:10:09.703833384 +0530
+++ gcc/testsuite/gcc.target/aarch64/vect-fp.x	2013-01-29 14:11:16.909568490 +0530
@@ -7,6 +7,16 @@ typedef double *__restrict__ pRF64;
  extern float fabsf (float);
  extern double fabs (double);

+#define DEF3a(fname, type, op) \
+			 void  fname##_##type (pR##type a,   \
+					       pR##type b,   \
+					       pR##type c)   \
+			 {                                   \
+			   int i;                            \
+			   for (i=0; i<16; i++)              \

GNU style, spaces around '=' and '<'.


--- gcc/testsuite/gcc.target/aarch64/vect.x	2013-01-24 20:10:09.703833384 +0530
+++ gcc/testsuite/gcc.target/aarch64/vect.x	2013-01-29 18:37:32.321808454 +0530
@@ -138,3 +138,18 @@ long long reduce_add_s64 (pRINT64 a)

    return s;
  }
+
+void sabd (pRINT a, pRINT b, pRINT c)
+{
+  int i;
+  for (i=0;i<16;i++)
+    c[i] = abs (a[i] - b[i]);
+}
+
+void saba (pRINT a, pRINT b, pRINT c)
+{
+  int i;
+  for (i=0;i<16;i++)
+    c[i] += abs (a[i] - b[i]);
+}
+

GNU style please.


Cheers
/Marcus



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]