This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Temporarily revert Steven's PCH changes for 4.8 (PR pch/54117)


On 02/13/13 13:07, Jakub Jelinek wrote:
On Wed, Feb 13, 2013 at 11:23:24AM -0700, Jeff Law wrote:
On 02/13/13 08:54, Jakub Jelinek wrote:
That looks just like the patch I have here.  Yet, I'm still seeing failures:

Running target unix/-m32/-gstabs
Using /usr/share/dejagnu/baseboards/unix.exp as board description
file for target.
Using /usr/share/dejagnu/config/unix.exp as generic interface file
for target.
Using /home/gcc/GIT/gcc/gcc/testsuite/config/default.exp as
tool-and-target-specific interface file.
Running /home/gcc/GIT/gcc/gcc/testsuite/gcc.dg/pch/pch.exp ...
FAIL: gcc.dg/pch/decl-3.c  -O0 -g assembly comparison
FAIL: gcc.dg/pch/decl-3.c   -O0  assembly comparison
FAIL: gcc.dg/pch/decl-3.c   -O1  assembly comparison
FAIL: gcc.dg/pch/decl-3.c   -O2  assembly comparison
FAIL: gcc.dg/pch/decl-3.c   -O3 -fomit-frame-pointer  assembly comparison
FAIL: gcc.dg/pch/decl-3.c   -O3 -g  assembly comparison
FAIL: gcc.dg/pch/decl-3.c   -Os  assembly comparison
FAIL: gcc.dg/pch/decl-4.c  -O0 -g assembly comparison
FAIL: gcc.dg/pch/decl-4.c   -O0  assembly comparison
FAIL: gcc.dg/pch/decl-4.c   -O1  assembly comparison
FAIL: gcc.dg/pch/decl-4.c   -O2  assembly comparison
FAIL: gcc.dg/pch/decl-4.c   -O3 -fomit-frame-pointer  assembly comparison
FAIL: gcc.dg/pch/decl-4.c   -O3 -g  assembly comparison
FAIL: gcc.dg/pch/decl-4.c   -Os  assembly comparison
[ ... ]

Can you double-check your testing output?

Yes, I've double checked it. Fresh trunk, got all of gcc.dg/pch/{decl-{3,4},struct-1,system-1,valid-1}.c failures for -m32/-gstabs as well as -m64/-gstabs, both with gcc that has #define HAVE_GAS_CFI_DIRECTIVE {0,1} in auto-host.h. Applying the patch cured all of those failures, except for valid-1.c (which is fine, as that test assumes no -g* switches be present by default).
I just wiped clean and tried again using your patch and I still see massive failures with -gstabs.

I'd like to know why we're getting different results before approving the patch.

jeff


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]