This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: PR target/52555: attribute optimize is overriding command line options
Aldy Hernandez <aldyh@redhat.com> writes:
> Richard.
>
> I made all the changes you suggested.
>
> I also changed other instances of s/this_target_optabs/this_fn_optabs/
> which I forgot in the previous iteration. And I also changed
> save_optabs_if_changed() to use this_fn_optabs, since init_all_optabs()
> will generate the optabs into this_fn_optabs.
Sorry, just noticed:
> + /* If the optabs changed, record it in the node. */
> + if (memcmp (tmp_target_optabs, &default_target_optabs,
> + sizeof (struct target_optabs)))
This should be this_target_optabs rather than &default_target_optabs.
Nothing but target code and initialisers should use &default_target_optabs
directly.
I don't think that needs a retest though. It only makes a difference
on MIPS.
Looks good to me otherwise. If there's any fallout on MIPS (hopefully not)
I'll fix it up after the commit.
Thanks,
Richard