This is the mail archive of the mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch, Fortran] Fix PR 56224

Thomas Koenig wrote:
Am 09.02.2013 11:22, schrieb Tobias Burnus:

Why did you put a FIXME there? What's wrong with adding the directory here?

I think module files are different enough from include files that I would like to have them in different directories.

I think they are similar enough to be in one directory - especially as include files are very unlikely to ever end in ".mod" and, thus, they can happily live alongside each other. Hence, I wouldn't put a FIXME there.

This version of the patch should fix that particular issue, and also has
no test cases.
Regression-tested.  OK?

OK. Thanks for the patch after fixing the nit below.

2013-02-09 Thomas Koenig <>

        PR fortran/56224
        * gfortran.h (gfc_add_include_path):  Add boolean argument
        for warn.
        * scanner.c (gfc_add_include_path):  Pass along warn argument
        to add_path_to_list.
        * options.c (gfc_post_options):  Add true warn argument to
        (gfc_handle_module_path_options):  Likewise.
        (gfc_handle_option): Also gfc_add_include_path for intrinsic
        modules, without warning.

-gfc_add_include_path (const char *path, bool use_for_modules, bool file_dir)
+gfc_add_include_path (const char *path, bool use_for_modules, bool file_dir, bool warn)

That line is too long.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]