This is the mail archive of the
mailing list for the GCC project.
Re: [PATCH] Multiversioning fixes (PR c++/55742, take 2)
Is this alright to commit?
On Thu, Feb 7, 2013 at 4:10 PM, Sriraman Tallam <firstname.lastname@example.org> wrote:
> On Thu, Feb 7, 2013 at 6:29 AM, Jason Merrill <email@example.com> wrote:
>> On 02/06/2013 08:39 PM, Sriraman Tallam wrote:
>>> +// Test to check if an error is generated when virtual functions
>>> +// are multiversioned.
>> This seems like a TODO, rather than something to test for. I don't see any
>> reason why we couldn't support multiversioned virtual functions.
>>> error_at (DECL_SOURCE_LOCATION (decl),
>>> - "Virtual function versioning not supported\n");
>>> + "Virtual function multiversioning not supported\n");
>> And so this should be a sorry rather than an error.
> Attached a new patch with these changes. Also made more minor changes
> to config/i386/i386.c.