This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, libstdc++] Fix 22_locale/time_get/get_weekday/char/38081-[12].cc tests for glibc 2.17
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Paolo Carlini <paolo dot carlini at oracle dot com>, GNU C Library <libc-alpha at sourceware dot org>
- Cc: Julian Brown <julian at codesourcery dot com>, gcc-patches at gcc dot gnu dot org, "libstdc++" <libstdc++ at gcc dot gnu dot org>
- Date: Mon, 11 Feb 2013 09:28:15 -0800
- Subject: Re: [PATCH, libstdc++] Fix 22_locale/time_get/get_weekday/char/38081-[12].cc tests for glibc 2.17
- References: <20130211153359.74f27ab4@octopus> <511927E9.7050606@oracle.com>
On Mon, Feb 11, 2013 at 9:18 AM, Paolo Carlini <paolo.carlini@oracle.com> wrote:
> Hi,
>
>
> On 02/11/2013 04:33 PM, Julian Brown wrote:
>>
>> Hi,
>>
>> It seems that glibc 2.17 changes the abbreviated names of weekdays for
>> "ru_RU" locales by removing an extraneous ".", as described in:
>>
>> http://sourceware.org/bugzilla/show_bug.cgi?id=10873
>>
>> An earlier patch (circa glibc 2.14) changed (IIUC!) archaic/unusual
>> three-letter abbreviations to more-common two-letter abbreviations, but
>> included dots after each weekday name, which was apparently still wrong.
>> But, the two tests of this feature in the libstdc++ testsuite expect
>> those dots to be present, so they fail.
>>
>> So, the attached patch simply removes the expectation that dots are
>> present in the abbreviated names from the libstdc++ tests in question,
>> if the glibc version in use is recent enough.
>>
>> The tests pass (with a current gcc, trunk eglibc) with the attached
>> patch, and fail (for me) without it (cross-testing to ARM Linux, for
>> no particular reason). OK to apply?
>
> I think it's Ok, yes. Thanks. However, I would appreciate if somebody with a
> glibc 2.17 system at hand could double check. Maybe HJ?
>
I am not familiar with locale. CC to glibc mailing list.
--
H.J.