This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Multiversioning fixes (PR c++/55742, take 2)

On Thu, Feb 7, 2013 at 6:29 AM, Jason Merrill <jason@redhat.com> wrote:
> On 02/06/2013 08:39 PM, Sriraman Tallam wrote:
>>
>> +// Test to check if an error is generated when virtual functions
>> +// are multiversioned.
>
>
> This seems like a TODO, rather than something to test for.  I don't see any
> reason why we couldn't support multiversioned virtual functions.
>
>>      error_at (DECL_SOURCE_LOCATION (decl),
>> -             "Virtual function versioning not supported\n");
>> +             "Virtual function multiversioning not supported\n");
>
>
> And so this should be a sorry rather than an error.

Attached a new patch with these changes. Also made more minor changes
to config/i386/i386.c.

Thanks
Sri

>
> Jason
>

Attachment: mv.txt
Description: Text document

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]