This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] fix PR sanitizer/55617 via qsort
- From: Mike Stump <mrs at mrs dot kithrup dot com>
- To: Jack Howarth <howarth at bromo dot med dot uc dot edu>
- Cc: gcc-patches at gcc dot gnu dot org, jakub at redhat dot com, glider at google dot com, dodji at redhat dot com, kcc at google dot com, dvyukov at google dot com, mikestump at comcast dot net, iain at codesourcery dot com
- Date: Mon, 4 Feb 2013 11:23:09 -0800
- Subject: Re: [PATCH] fix PR sanitizer/55617 via qsort
- References: <20130204172259.GA23606@bromo.med.uc.edu>
On Feb 4, 2013, at 9:22 AM, Jack Howarth <howarth@bromo.med.uc.edu> wrote:
> Currently darwin is unable to utilize libasan with constructors due to the lack of
> constructor priority support on that target.
> Okay for gcc trunk?
Since asan doesn't need cross translation unit priorities, the patch is sufficient to fix all of the semantics needed for asan.
I still have a preference, though small, for stable_sort instead of qsort, absent performance data saying qsort is better.
Ok.
> ps The issue of inter module priority support remains unresolved (as it is in clang/llvm).
> The only solution for both compilers is to reorder the linkage of the modules to insure that the module with the asan constructor appears first.
Since asan doesn't care who goes first, we don't need priorities across translation units for it.