This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch libstdc++]: Fix LLP64 pointer-size issues for cxxabi, eh_alloc, and hash_bytes


2012/12/21 Paolo Carlini <paolo.carlini@oracle.com>:
> Hi,
>
>
> On 12/21/2012 08:59 AM, Kai Tietz wrote:
>>
>> Index: libsupc++/cxxabi.h
>> ===================================================================
>> --- libsupc++/cxxabi.h  (Revision 194655)
>> +++ libsupc++/cxxabi.h  (Arbeitskopie)
>> @@ -356,7 +356,7 @@ namespace __cxxabiv1
>>     {
>>     public:
>>       const __class_type_info*  __base_type;  // Base class type.
>> -    long                       __offset_flags;  // Offset and info.
>> +    intptr_t                   __offset_flags;  // Offset and info.
>
> I don't think this is a safe change, in the sense that intptr_t is in
> general only available on targets providing the C99 stdint.h.
>
> Paolo.

Well, I thought it is always present for gcc due gstdint.h header, but
well, using ptrdiff_t here instead would be ok too IMHO, and later is
compatible to none C99-systems.

Ok, with that change (and remove of later cast to ptrdiff_t for it)?

Kai


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]