This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] ree.c: don't abuse GTY
- From: Richard Biener <richard dot guenther at gmail dot com>
- To: Steven Bosscher <stevenb dot gcc at gmail dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Fri, 7 Dec 2012 10:08:11 +0100
- Subject: Re: [patch] ree.c: don't abuse GTY
- References: <CABu31nO20-qqcMU68LihzsSC+cXs7n=ppkB6RgAZVn4gwuONBA@mail.gmail.com>
On Fri, Dec 7, 2012 at 1:05 AM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
> Hello,
>
> ree.c's data structures are not GC-allocated, so its GTY markers and
> its TODO_ggc_collect are unnecessary.
>
> Will commit as obvious after the usual testing on my favourite platforms :-)
IMHO TODO_ggc_collect should go and we should collect after each pass run.
Richard.
> * ree.c (struct ext_cand): Remove GTY markers.
> (pass_ree): Remove TODO_ggc_collect.
>
> Index: ree.c
> ===================================================================
> --- ree.c (revision 194247)
> +++ ree.c (working copy)
> @@ -243,7 +243,7 @@
>
> /* This structure represents a candidate for elimination. */
>
> -typedef struct GTY(()) ext_cand
> +typedef struct ext_cand
> {
> /* The expression. */
> const_rtx expr;
> @@ -958,7 +958,6 @@
> 0, /* properties_provided */
> 0, /* properties_destroyed */
> 0, /* todo_flags_start */
> - TODO_ggc_collect |
> TODO_verify_rtl_sharing, /* todo_flags_finish */
> }
> };