Re: [patch] Hookize CFG DOT graph dumping

[Xinliang David Li <davidxl at google dot com>]

Nice.  We used to just do post-processing of the dumps with -blocks option.

I assume the graph dump does not support multiple function dump (I
noticed that the previous function's dump gets overwritten). This
reminds me  that I need to resurrect my per-function dump support, and
dump-before/after patches at some point.

Why can't the dot dumper dump the count/frequency/branch prob
information? The attached dot file is generated from an assembly file
dumped with -S -dA option.

thanks,

David

On Mon, Dec 3, 2012 at 8:54 AM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
> Hello,
>
> This is the last patch in this series for now, unless I can convince
> everyone that some files should be renamed after all these changes :-)
>
> The attached patch makes graph.c independent of the IR contained in
> the CFG it dumps. For this, I made the node label dumping routine a
> cfghook. I also changed the dumper to take a struct function rather
> than a fndecl tree, and use the funcdef_no as the unique number for
> the function. This helps when annotating the graph with profile
> information from .gcda files (I have a tool for that :-).
>
> I also noticed I introduced a bug in the dumping of REG_NOTEs in slim
> RTL dumps. Also fixed by this patch.
>
> Bootstrapped&tested on powerpc64-unknown-linux-gnu. OK?
>
> Ciao!
> Steven

Attachment: t.dot
Description: Binary data