This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, PR 54394] Compute loops when generating inline summaries
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: GCC Patches <gcc-patches at gcc dot gnu dot org>, Martin Jambor <mjambor at suse dot cz>
- Date: Mon, 3 Dec 2012 10:07:56 -0800
- Subject: Re: [PATCH, PR 54394] Compute loops when generating inline summaries
- References: <20120829182400.GC3395@virgil.arch.suse.de> <20120831085332.GD7104@kam.mff.cuni.cz> <20120831095616.GA6468@virgil.arch.suse.de> <20120831100633.GA12083@kam.mff.cuni.cz> <20120831144134.GB6468@virgil.arch.suse.de> <CAMe9rOp2xDOZd9DX2Q3EXCuDK5BtSwzdp=_-dYW9hh559__Q1g@mail.gmail.com>
On Mon, Dec 3, 2012 at 9:50 AM, H.J. Lu <hjl.tools@gmail.com> wrote:
> On Fri, Aug 31, 2012 at 7:41 AM, Martin Jambor <mjambor@suse.cz> wrote:
>> Hi,
>>
>> On Fri, Aug 31, 2012 at 12:06:33PM +0200, Jan Hubicka wrote:
>>> >
>>> > This is not required to make hints working, it is necessary because of
>>> > the following line a in estimate_function_body_sizes:
>>> >
>>> > es->loop_depth = bb_loop_depth (bb);
>>> >
>>> > which always yields zero if we don't have loops computed. So I can
>>> > skip the computation only if we don't care about loop depths in early
>>> > inlining either. Should I skip it?
>>>
>>> Only place we care is the badness computation and only if profile guessing is off,
>>> so just initialize it to 0 for early inliner.
>>>
>>
>> Thanks. For the record, this is what I have committed.
>>
>> Martin
>>
>>
>> 2012-08-31 Martin Jambor <mjambor@suse.cz>
>>
>> PR middle-end/54394
>> * ipa-inline-analysis.c (estimate_function_body_sizes): Compute
>> dominance info and loops whenever optimizing.
>>
>>
>
> This caused:
>
> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55564
>
Oops. Wrong link. Please ignore this.
--
H.J.