Re: [RFA/ARM] Fix PR54974: Thumb literal pools don't handle PC rounding

[Matthew Gretton-Dann <matthew dot gretton-dann at linaro dot org>]

On 24 November 2012 00:27, Ramana Radhakrishnan
<ramana.gcc@googlemail.com> wrote:
> On Wed, Nov 21, 2012 at 7:59 PM, Matthew Gretton-Dann
> <matthew.gretton-dann@linaro.org> wrote:
[snip]
>> The fix is to decrease the pool_range of all insns by 2 when generating
>> Thumb code.  There is no need to change neg_pool_range values as rounding
>> down here will reduce the distance of the literal pool.
>
> A comment about this fact around thumb2_pool_range would be appropriate.
>
[snip]
>>
>> Tested arm-none-linux-gnueabi cross, and with the testcase attached to the
>> PR.  No added testcase in the patch as this code is sensitive to other code
>> generation and so it is not easy to generate a testcase which will reliably
>> test this condition.
>>
>> OK for trunk, 4.7, and 4.6?
>
>
> Ok for trunk today - please wait a few days before backporting into
> 4.6 and 4.7 to see what the fallout is like . Watch out for any
> fallout with the auto-testers.

The attached is what was actually committed as revision 193930
(original patch + requested comment).

Thanks,

Matt

--
Matthew Gretton-Dann
Linaro Toolchain Working Group
matthew.gretton-dann@linaro.org

Attachment: thumb-literal-pools-actually-committed.txt
Description: Text document