This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [libsanitizer] merge fresh sources from upstream


On Fri, Nov 23, 2012 at 3:15 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> Hi!
>
> Ok, provided it has been properly tested

The upstream library is continuously tested on Linux, Mac, Windows and Android
using the existing test suite (unfortunately, the build bots are
private so far).

> (given that we don't have
> almost any testsuite so far, that is at least
> rm -rf */{*/,}libsanitizer;
> make # -jN
> in the build tree and

The build passes.

> make -C gcc check-g{cc,++} RUNTESTFLAGS='--target_board=unix\{-m32,-m64\} asan.exp'

The tests fail even w/o this change for me.
The reports look like
    #0 0x555c96f2 in  ??:0
    #1 0x80488d1 in  ??:0
i.e. either the debug info is missing or the symbolizer script is not working.
Any suggestion?

> ).
>
> On Fri, Nov 23, 2012 at 03:03:22PM +0400, Konstantin Serebryany wrote:
>  2012-11-23  Kostya Serebryany  <kcc@google.com>
>
> +       * merge.sh: support tsan, support added/removed files.
> +       * tsan/Makefile.am: remove deleted files.
> +       * tsan/Makefile.in: ditto
>
> ChangeLog entry description start with capital letter, so
> Support tsan.  For tsan/Makefile.am it is better to be accurate,
>         * tsan/Makefile.am (tsan_files): Remove tsan_printf.cc.
> ditto is wrong (no dot at the end, no capital letter at the beginning,
> but more importantly, as Makefile.in is a generated file, you want:
>         * tsan/Makefile.in: Regenerated.

Ooops. I actually edited it. How do I regenerate it? (I beg my pardon
for a complete ignorance)


> ).
>
> +       * other files: merge from upstream r168511. Note that HACKY_CALL in
> +       tsan is disabled for now. See PR sanitizer/55376.
>
> Just mention
>         Merge from upstream r168511
> above the merge.sh line, ChangeLog entry shouldn't contain notes etc.
> +
> +2012-11-23  Kostya Serebryany  <kcc@google.com>
> +
>         * merge.sh: a script that will help merges from upstream.
>
> This should have been
>         * merge.sh: New file.
>
>
>         Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]