This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Change -faddress-sanitizer to -fsanitize=address
On Mon, Nov 19, 2012 at 11:21:27AM -0800, Wei Mi wrote:
> I cannot remove RejectNegative and use -fno-sanitize=address, or else
> I will break an assertion (opts-common.c:614). The assertion requires
> -fxxx=var options set RejectNegative if var is of enumerater type. I
> see that all the other -fxxx=xxx options in common.opt set
> RejectNegative.
>
> Is it ok for me to checkin the current patch and submit another patch
> if there is a better way to do it?
If the two options are independent, then please don't commit the current
patch, rewrite it not to use enumerated type, use two different variables
etc.
fsanitize=address
Common Report Var(flag_asan)
Enable AddressSanitizer, a memory error detector
fsanitize=thread
Common Report Var(flag_tsan)
Enable ThreadSanitizer, a thread race detector
or something similar in common.opt, and no changes to places that use
flag_asan internally. If this works, the patch for trunk right now
shouldn't include fsanitize=thread bits though, that should be moved over
into the tsan patch.
Jakub