This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: Add --with-build-config=bootstrap-asan support


On Sun, Nov 18, 2012 at 7:59 AM, Hans-Peter Nilsson <hp@bitrange.com> wrote:
> On Sun, 18 Nov 2012, H.J. Lu wrote:
>> On Sun, Nov 18, 2012 at 7:28 AM, Paolo Bonzini <bonzini@gnu.org> wrote:
>> > Il 18/11/2012 00:54, H.J. Lu ha scritto:
>> >> +@if gcc-bootstrap
>> >> +ifneq ($(filter bootstrap-asan,$(BUILD_CONFIG)),)
>> >> +LIBASAN_LIBS=-B$$r/prev-$(TARGET_SUBDIR)/libsanitizer/asan/.libs
>> >> +endif
>> >> +@endif gcc-bootstrap
>> >
>> > Do you need this to be here?  POSTSTAGE1_*_EXPORT is only used when
>> > bootstrapping, and they are defined with "=" so the definition could be
>> > placed (or so it seems at first look) in bootstrap-asan.mk.
>> >
>>
>> It works. I will post a new patch to include a workaround for
>>
>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=55380
>>
>> Thanks.
>
> Nice, but I agree with the other poster that this'd IMHO be
> better as --enable-checking=asan (or actually,
> --enable-checking=all,asan).
>

ASAN isn't a checking feature enabled in GCC source
without any compiler requirements.  It is a compiler
feature, similar to LTO. For example, you can't enable
ASAN in stage 1 since stage 1 compiler may not support
ASAN.  I believe  --with-build-config=bootstrap-asan
is the best fit.

-- 
H.J.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]