This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 00/13] Request to merge Address Sanitizer in


On Fri, Nov 16, 2012 at 05:00:22PM +0100, Jakub Jelinek wrote:
> On Fri, Nov 16, 2012 at 10:57:04AM -0500, Jack Howarth wrote:
> > +case "$host" in
> > +  *-*-darwin*) MACH_OVERRIDE=true ;;
> > +  *) MACH_OVERRIDE=false ;;
> > +esac
> > +AM_CONDITIONAL(USING_MACH_OVERRIDE, $MACH_OVERRIDE)
> > +
> 
> Shouldn't AM_CONDITIONAL follow AM_INIT_AUTOMAKE?  I'd say move it
> before AC_CONFIG_FILES or so.
> 
> 	Jakub

Jakub,
   Done. Any chance you can commit this one (with yourself in the ChangeLog
for the file imports from llvm) before this one bit-rots? Thanks in advance.
         Jack
ps The configure.ac readjustment was tested on x86_64-apple-darwin12.

Attachment: asan_v7.diff
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]