This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: VEC re-write [patch 09/25]


>>>>> "Diego" == Diego Novillo <dnovillo@google.com> writes:

Diego> 2012-11-15  Diego Novillo  <dnovillo@google.com>
Diego> 	Adjust for new vec API (http://gcc.gnu.org/wiki/cxx-conversion/cxx-vec)
Diego> 	* boehm.c: Use new vec API in vec.h.
Diego> 	* class.c: Likewise.
Diego> 	* constants.c: Likewise.
Diego> 	* decl.c: Likewise.
Diego> 	* expr.c: Likewise.
Diego> 	* java-tree.h: Likewise.
Diego> 	* jcf-parse.c: Likewise.
Diego> 	* resource.c: Likewise.
Diego> 	* verify-glue.c: Likewise.

Looks nice.  Thanks.
I have one nit:

Diego>  	      = build_utf8_ref (unmangle_classname (IDENTIFIER_POINTER (sig),
Diego> -						    IDENTIFIER_LENGTH (sig)));
Diego> -	    e = &VEC_index (constructor_elt, v, idx--);
Diego> +		    IDENTIFIER_LENGTH (sig)));
Diego> +	    e = &(*v)[idx--];

Looks like a spurious reindentation of the IDENTIFIER_LENGTH line.

Tom


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]