This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Fix PRE heuristic for partial insertions
- From: Steven Bosscher <stevenb dot gcc at gmail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Jan Hubicka <hubicka at ucw dot cz>, gcc-patches at gcc dot gnu dot org, rguenther at suse dot de
- Date: Thu, 15 Nov 2012 23:04:12 +0100
- Subject: Re: Fix PRE heuristic for partial insertions
- References: <20121115102554.GE12910@kam.mff.cuni.cz> <20121115154530.GV1886@tucnak.redhat.com>
On Thu, Nov 15, 2012 at 4:45 PM, Jakub Jelinek wrote:
> On Thu, Nov 15, 2012 at 11:25:55AM +0100, Jan Hubicka wrote:
>> PR tree-optimization/54717
>> * tree-ssa-pre.c (do_partial_partial_insertion): Consider also edges
>> with ANTIC_IN.
>
> As Richard is still away, Steven, could you please comment on this?
I'm not very familiar with the partial-partial bits of PRE but Honza's
fix makes sense after glancing at how PA_IN is computed: ANTIC_IN is
filtered, so the set of partially or fully anticipated values in the
successor block is PA_IN U ANTIC_IN and we should look in both sets.
Ciao!
Steven