This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Copy libsanitizer from llvm at revision 167890


On Thu, Nov 15, 2012 at 07:07:46PM +0400, Dmitry Vyukov wrote:
> On Thu, Nov 15, 2012 at 6:56 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> 
> > On Thu, Nov 15, 2012 at 06:54:43PM +0400, Dmitry Vyukov wrote:
> > > Yes, I think people will search by "libsanitizer" (or "asan").
> > >
> > > Do I need to add Jakub Jelinek as reviewer as well?
> >
> > I can add myself after you commit it, or you can add me.
> >
> 
> 
> I've added you as well.
> If nobody objects to this version, I will commit it.
> 
> 
> Index: ChangeLog
> ===================================================================
> --- ChangeLog (revision 193530)
> +++ ChangeLog (working copy)
> @@ -1,3 +1,8 @@
> +2012-11-15  Dmitry Vyukov  <dvyukov@google.com>
> +
> +        * MAINTAINERS: (libsanitizer, asan.c): Add myself
> + and Kostya Serebryany (kcc@google.com).

The ChangeLog entry is wrong, there should be a tab instead of 8
spaces at the beginning, the text is out of date to what you changed
and if you need more than one line, also the other lines need to be
indented by a single tab.

	Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]