This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: User directed Function Multiversioning via Function Overloading (issue5752064)

Patch committed now after making the changes.

Thanks,
-Sri.

On Mon, Nov 12, 2012 at 6:39 PM, Jason Merrill <jason@redhat.com> wrote:
> On 11/12/2012 08:11 PM, Sriraman Tallam wrote:
>>
>> +           && !targetm.target_option.function_versions (fn,
>> +                TREE_PURPOSE (match)))
>
>
> The second argument should be lined up with the left paren if it's on a
> different line.  Perhaps formatting this as
>
> && !(targetm.target_option.function_versions
>      (fn, TREE_PURPOSE (match))))
>
> would be better.
>
>> +      error_at (input_location, "Use of multiversioned function "
>> +           "Multiversioning needs ifunc which is not supported "
>
>
> We don't capitalize the first letter of a diagnostic.
>
> OK with those changes.
>
> Jason
>
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]