This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Less restrictive regex in const-uniq-1.c


On Tue, Nov 6, 2012 at 8:07 AM, Andrew Pinski <pinskia@gmail.com> wrote:
> On Tue, Nov 6, 2012 at 6:54 AM, David Edelsohn <dje.gcc@gmail.com> wrote:
>> The regex in const-uniq-1.c assumes ELF label format, which does not
>> match AIX XCOFF.  The following patch broadens the regex so that it
>> also correctly matches on AIX.
>>
>>         * const-uniq-1.c: Expand regex to match AIX XCOFF labels.
>>
>> Index: const-uniq-1.c
>> ===================================================================
>> --- const-uniq-1.c      (revision 193203)
>> +++ const-uniq-1.c      (working copy)
>> @@ -20,5 +20,5 @@
>>    return a[i+1];
>>  }
>>
>> -/* { dg-final { scan-tree-dump-times "L\\\$?C0" 2 "gimple" } } */
>> +/* { dg-final { scan-tree-dump-times "L\\\$?C\\\.*0" 2 "gimple" } } */
>
> I think .* will match too much as it will match newlines too.  I think
> [^\n\]* is better.

Just to correct my self, I missed all of the \ before the '.' so this
change is fine with respect of not matching too much.

Thanks,
Andrew pinski


>
> Thanks,
> Andrew Pinski
>
>
>>  /* { dg-final { cleanup-tree-dump "gimple" } } */


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]