This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH 08/10] Factorize condition insertion code out of build_check_stmt

From: Dodji Seketeli <dodji at redhat dot com>
To: Jakub Jelinek <jakub at redhat dot com>
Cc: gcc-patches at gcc dot gnu dot org, dnovillo at google dot com, wmi at google dot com, davidxl at google dot com, konstantin dot s dot serebryany at gmail dot com
Date: Mon, 05 Nov 2012 21:25:29 +0100
Subject: Re: [PATCH 08/10] Factorize condition insertion code out of build_check_stmt
References: <1351799566-31447-1-git-send-email-dodji@redhat.com> <87pq3v8vmi.fsf@redhat.com> <87objf7gku.fsf_-_@redhat.com> <20121105154958.GN1881@tucnak.redhat.com>

Jakub Jelinek <jakub@redhat.com> writes:

> On Sat, Nov 03, 2012 at 12:03:45AM +0100, Dodji Seketeli wrote:
>> +  int fallthrough_probability =
>> +    then_more_likely_p
>> +    ? PROB_VERY_UNLIKELY
>> +    : PROB_ALWAYS - PROB_VERY_UNLIKELY;
>
> Just a formatting nit, I think = needs to go on the next line, so
>
>   int fallthrough_probability
>     = then_more_likely_p
>       ? PROB_VERY_UNLIKELY
>       : PROB_ALWAYS - PROB_VERY_UNLIKELY;

OK.  Patch updated in my local tree.

> No need to repost for that.

OK, thanks.

-- 
		Dodji

References:
- [PATCH 00/13] Request to merge Address Sanitizer in
  - From: dodji
- Re: [PATCH 00/13] Request to merge Address Sanitizer in
  - From: Dodji Seketeli
- [PATCH 08/10] Factorize condition insertion code out of build_check_stmt
  - From: Dodji Seketeli
- Re: [PATCH 08/10] Factorize condition insertion code out of build_check_stmt
  - From: Jakub Jelinek

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]