This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [asan] change libasan to libsanitizer


Ok, I will check in the patch.

Thanks,
Wei.

On Thu, Nov 1, 2012 at 3:03 PM, Xinliang David Li <davidxl@google.com> wrote:
> On Thu, Nov 1, 2012 at 2:23 PM, Xinliang David Li <davidxl@google.com> wrote:
>> On Thu, Nov 1, 2012 at 2:17 PM, Wei Mi <wmi@google.com> wrote:
>>> Thanks for the suggestion!
>>>
>>> The planned svn commands will be:
>>>
>>> svn mv libasan libsanitizer
>>> svn add libsanitizer/asan
>>> svn add libsanitizer/tsan
>>
>> Probably keep the tsan creation out of this patch.
>
> If there is no other objections, this patch is ok for asan branch with
> the above. There might be errors spotted under trunk review, but that
> should be fine ..
>
> thanks,
>
> David
>
>>
>> David
>>
>>> cd libsanitizer
>>> for i in `ls asan_*`; do
>>>   svn mv $i asan/$i
>>> done
>>>
>>> Then apply the two patches attached on top of that. patch.1.txt is to
>>> handle the toplevel configure and Makefile changes. patch.2.txt is to
>>> handle the configure and Makefile changes in libsanitizer.
>>>
>>> Thanks,
>>> Wei.
>>>
>>> On Thu, Nov 1, 2012 at 1:34 PM, Xinliang David Li <davidxl@google.com> wrote:
>>>> that sounds good to me.
>>>>
>>>> David
>>>>
>>>> On Thu, Nov 1, 2012 at 1:31 PM, Jakub Jelinek <jakub@redhat.com> wrote:
>>>>> On Thu, Nov 01, 2012 at 01:19:42PM -0700, Xinliang David Li wrote:
>>>>>> Will it be easier if you just rolled back your previous libasan
>>>>>> library changes, and resubmit it with the restructured directory?
>>>>>
>>>>> I think better would be if you didn't apply it as a patch with lots of svn
>>>>> add/svn rm commands, but instead just svn mv the directory or files.
>>>>> So it would be better if you could post the planned svn commands
>>>>> and the patch that would be applied on top of that.
>>>>>
>>>>>         Jakub


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]