This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix PR 53743 and other -freorder-blocks-and-partition failures (issue6823047)
- From: Steven Bosscher <stevenb dot gcc at gmail dot com>
- To: Teresa Johnson <tejohnson at google dot com>
- Cc: reply at codereview dot appspotmail dot com, David Li <davidxl at google dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
- Date: Thu, 1 Nov 2012 22:45:56 +0100
- Subject: Re: [PATCH] Fix PR 53743 and other -freorder-blocks-and-partition failures (issue6823047)
- References: <20121030052000.A4D0F61459@tjsboxrox.mtv.corp.google.com> <CABu31nOdJcsvQE8=9RAXocj247GQN8BmnJoSdJVJ2vwX3cCJdQ@mail.gmail.com> <CABu31nMjtSNEW-1nGtg_77BDHHS7Wi-zzkfy6nX5Fux3q1kSwg@mail.gmail.com> <CABu31nOxJjohhS8zqE9_cS8LwW_O8QfsfyfLj-WqwhkbK3kjCw@mail.gmail.com> <CABu31nPV=+b=1iZG4nXsoE_u4PtOcWMG3V9n3+9zabkvfxBkaw@mail.gmail.com> <CAAe5K+W0Z9jgfAkL1fD6Y2BZEZNcV-1oTfQ2oxBVnJLckz3OtA@mail.gmail.com> <CABu31nMKMjNZvtJJwfimt-N8OUh2veEsGXdJ2UOFEigSZVNyGA@mail.gmail.com> <CAAe5K+UYQQAu4EGHXWa=uoLuN3AA9sGiAxC-wx3WmGxiwgk=Mw@mail.gmail.com> <CAAe5K+Ujg1mTKhnBsWxtp4Jp3f0NdJ=Fmfbqn6Ry-HrdAmmPjg@mail.gmail.com>
On Thu, Nov 1, 2012 at 10:26 PM, Teresa Johnson wrote:
> I'll do some testing of the fix below, but do you have any comments on
> the correctness or the potential issue I raised (see my note just
> below the patch)?
Sorry, I don't know the pro- and epilogue threading code well enough
to be of any help to you...
> Do you recommend pursuing the move of the bb partition phase until
> later, after we leave cfglayout mode? I need to revisit to see if my
> prologue/epilogue fix below also addresses the issue I saw when I
> tried moving it.
I think it should not be moved, cfglayout mode is the natural mode for
this kind of CFG transformations. But someone will have to tackle the
force_nonfallthru issue.
Ciao!
Steven