This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] Normalize more bitmap function names.


On 11/1/12, Diego Novillo <dnovillo@google.com> wrote:
> On 2012-10-31 13:41 , Lawrence Crowl wrote:
>> This patch normalizes more bitmap function names.
>>
>>    sbitmap.h
>>
>>      TEST_BIT -> bitmap_bit_p
>>      SET_BIT -> bitmap_set_bit
>
> I wonder if it wouldn't it be more consistent if TEST_BIT became
> bitmap_test_bit() ?  I never particularly liked the lispy *_p
> convention.  But I don't really care much one way or the other.

The plan was to simply use the bitmap names, and given the
schedule I would prefer to leave it as is.

> The patch is OK.

Okay.  I will merge and commit.

-- 
Lawrence Crowl


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]