This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [patch] Unify bitmap interface.
On Tue, Oct 30, 2012 at 12:53 PM, Diego Novillo <dnovillo@google.com> wrote:
> On Mon, Oct 29, 2012 at 4:25 PM, Steven Bosscher <stevenb.gcc@gmail.com> wrote:
>> On Mon, Oct 29, 2012 at 7:54 PM, Diego Novillo wrote:
>>
>>> Sure. But the point is not to add more. We should mechanically strip
>>> all the #if 0 code from the tree, btw. No point keeping all that
>>> garbage around.
>>
>> Please no. A lot (if not most) if the #if 0 code serves as good
>> documentation for why something is *not* done, other pieces are there
>> to indicate possible enhancement, and some are useful for debugging.
>
> I never really bought into that line of reasoning. Documenting why an
> approach was not taken is better to do it in words than in code that
> will grow stale wrt the surrounding code. Similarly for possible
> enhancements. Prose is better than code in those cases. If debugging
> code is useful, then it can remain predicated on some debugging
> switch.
I agree with both of you - #if 0 code if it is useful as comment deserves
being rewritten as a comment.
Richard.
>
> Diego.