Re: Profile housekeeping 6/n (-fprofile-consistency-report)

[Jan Hubicka <hubicka at ucw dot cz>]

> On Thu, Oct 4, 2012 at 4:01 PM, Jan Hubicka wrote:
> >         * doc/invoke.texi (-fprofile-consistency-report): Document.
> >         * common.opt (fprofile-consistency-report): New.
> >         * toplev.h (dump_profile_consistency_report): Declare.
> >         * toplev.c (finalize): Call dump_profile_consistency_report.
> >         * passes.c (profile_record): New global var.
> >         (check_profile_consistency): New function.
> >         (dump_profile_consistency_report): New function.
> >         (execute_one_ipa_transform_pass): Call check_profile_consistency.
> >         (execute_one_pass): Likewise.
> 
> 
> Nice. And long overdue! :-)
> 
> 
> > +fprofile-consistency-report
> > +Common Report Var(profile_report)
> > +Report on consistency of profile
> 
> Maybe make this a -d flag instead of -f?

time-report and mem-report are also -f, so I guess we shall move all of them or none.
> 
> 
> > Index: passes.c
> > +/* Hold statistic about profile consistency.  */
> ...
> 
> I don't see why this should live in passes.c, can you please put it in
> a more logical place (profile.c, perhaps)?

Hmm, I guess predict.c then.
I had it there but then reminded Richard's effort to pull out functions that
are only called from elsehwere and not using anything from given unit ;)

Honza
> 
> Ciao!
> Steven