This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [C++ PATCH] Nit fix in build_new_1
- From: Richard Guenther <richard dot guenther at gmail dot com>
- To: Jakub Jelinek <jakub at redhat dot com>
- Cc: Jason Merrill <jason at redhat dot com>, gcc-patches at gcc dot gnu dot org
- Date: Thu, 27 Sep 2012 12:59:12 +0200
- Subject: Re: [C++ PATCH] Nit fix in build_new_1
- References: <20120927104435.GW1787@tucnak.redhat.com>
On Thu, Sep 27, 2012 at 12:44 PM, Jakub Jelinek <jakub@redhat.com> wrote:
> Hi!
>
> All INTEGER_CSTs are TREE_CONSTANT, I don't see the point
> in testing that. Ok for trunk?
Ok.
Thanks,
Richard.
> 2012-09-27 Jakub Jelinek <jakub@redhat.com>
>
> * init.c (build_new_1): Don't test TREE_CONSTANT
> of INTEGER_CST.
>
> --- gcc/cp/init.c.jj 2012-09-25 11:59:43.000000000 +0200
> +++ gcc/cp/init.c 2012-09-27 12:42:32.382457943 +0200
> @@ -2235,8 +2235,7 @@ build_new_1 (VEC(tree,gc) **placement, t
> {
> tree inner_nelts = array_type_nelts_top (elt_type);
> tree inner_nelts_cst = maybe_constant_value (inner_nelts);
> - if (TREE_CONSTANT (inner_nelts_cst)
> - && TREE_CODE (inner_nelts_cst) == INTEGER_CST)
> + if (TREE_CODE (inner_nelts_cst) == INTEGER_CST)
> {
> bool overflow;
> double_int result = TREE_INT_CST (inner_nelts_cst)
>
> Jakub