This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [Patch] PR54635: Add addr_space_t argument to mode_dependent_address_p
Hans-Peter Nilsson wrote:
> Georg-Johann Lay wrote:
>> mode_dependent_address_p is not sensitive to the address space of the passed
>> address. Thus, add an addr_space_t parameter to the hook.
>
> Borderline obvious. :) (J/k; the added functionality seems
> obvious but the implementation may have non-obvious issues,
> though I saw none.)
What specifically?
>> One more question:
>> This patch changes a target hook. Is there a place in the internals
>> that gathers changes by naming *all* the changed/extended/removed/poisoned
>> interfaces? So that developers can read the list of functions/macros/hooks
>> to learn if something interesting happened as they update the GCC sources?
>
> Someone once suggested an internal-changes web-page or file for
> the benefit of out-of-tree ports and patches, but I don't know
> what happened to that. I'd look in the wiki.
>
>> Diff'ing the internals texi is tedious and too much noise as it would be
>> helpful to get a briefing.
>>
>>
>> Johann
>>
>> PR 54635
>
> Better spell that "PR other/54635" in the ChangeLog; if you
> don't get the syntax right it won't automatically show up in
> bugzilla.
Okay with that change to the ChangeLog?
Being unsure about the component, I chose "other".
Is "middle-end" better?
AFAIK "PR12345", "PR 12345" and "PR component/12345" entries are recognized
and connected to bugzilla PRs?
Johann