This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]
Other format:	[Raw text]

Re: [PATCH, ARM] Constant vector permute for the Neon vext insn

From: Ramana Radhakrishnan <ramrad01 at arm dot com>
To: Christophe Lyon <christophe dot lyon at linaro dot org>
Cc: Richard Henderson <rth at redhat dot com>, Richard Earnshaw <Richard dot Earnshaw at arm dot com>, "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>
Date: Mon, 03 Sep 2012 10:58:47 +0100
Subject: Re: [PATCH, ARM] Constant vector permute for the Neon vext insn
References: <CAKdteOb98RYsXwJKjpAcPH=7JppTg=xSes4yRRfpeUx085d1Hg@mail.gmail.com> <50373DE0.8010208@arm.com> <CAKdteOaSEk_pREPcvYbGZDRCezSEGnRxcuCgMyhkefbpCfp9sw@mail.gmail.com> <CAKdteOaoxHMruRRhA57eLzkyYkN_KHfbKo3-7MfLZL8P_NmCRw@mail.gmail.com> <CAKdteOaz-8HNcRb9W8qO5MtVx6akLS3QFQEmQFYut9bWc5Zi2Q@mail.gmail.com> <5040DF68.2020608@redhat.com> <CAKdteOY2DR5uTYe37-ToVTcfJZDL4-0U=1bxSB5U6xzn_kHsCA@mail.gmail.com>
Reply-to: ramrad01 at arm dot com

On 09/03/12 09:59, Christophe Lyon wrote:

On 31 August 2012 17:59, Richard Henderson <rth@redhat.com> wrote:
On 2012-08-31 07:25, Christophe Lyon wrote:
+ offset = gen_rtx_CONST_INT (VOIDmode, location);
Never call gen_rtx_CONST_INT directly. Use GEN_INT.
Here is an updated patch with that small change.
For the record, there are quite a few existing calls to
gen_rtx_CONST_INT, maybe a cleanup pass is needed?

A set of cleanup patches are welcome.

This looks OK - thanks.

Ramana

References:
- Re: [PATCH, ARM] Constant vector permute for the Neon vext insn
  - From: Christophe Lyon

Index Nav:	[Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav:	[Date Prev] [Date Next]	[Thread Prev] [Thread Next]