This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [google] Modification of gcov pmu format to reduce gcda size bloat (issue 6427063)


I don't see any code where a string table is declared nor created ...

David


On Fri, Aug 24, 2012 at 2:26 PM, Chris Manghane <cmang@google.com> wrote:
> Also, what did you mean by there being missing string table management code?
>
>
> On Fri, Aug 24, 2012 at 2:23 PM, <cmang@google.com> wrote:
>>
>>
>> Ok, I fixed most of the problem you found. I'm not sure what happened
>> with gcov.c, but I'll try uploading it again.
>>
>>
>>
>> http://codereview.appspot.com/6427063/diff/5001/gcc/gcov-io.c
>> File gcc/gcov-io.c (right):
>>
>> http://codereview.appspot.com/6427063/diff/5001/gcc/gcov-io.c#newcode280
>> gcc/gcov-io.c:280: gcov_read_pmu_string_table_entry
>> (gcov_pmu_st_entry_t* st_entry,
>> On 2012/08/24 20:42:03, davidxl wrote:
>>>
>>> Fix format:
>>
>>
>>> ..entry_t  *st_entry,
>>
>>
>> Done.
>>
>>
>> http://codereview.appspot.com/6427063/diff/5001/gcc/gcov-io.c#newcode281
>> gcc/gcov-io.c:281: gcov_unsigned_t len ATTRIBUTE_UNUSED)
>> On 2012/08/24 20:42:03, davidxl wrote:
>>>
>>> Why having an unused parameter? Can it be used in assertion check?
>>
>>
>> I'm following the format of the pmu_branch_mispredict/load_latency_info
>> function defined above. Should I remove the ATTRIBUTE_UNUSED symbol from
>> them as well?
>>
>>
>> http://codereview.appspot.com/6427063/diff/5001/gcc/gcov-io.c#newcode830
>> gcc/gcov-io.c:830: print_pmu_string_table_entry (FILE *fp, const
>> gcov_pmu_st_entry_t* st_entry,
>> On 2012/08/24 20:42:03, davidxl wrote:
>>>
>>> Fix format.
>>
>>
>> Done.
>>
>>
>> http://codereview.appspot.com/6427063/diff/5001/gcc/gcov-io.c#newcode831
>> gcc/gcov-io.c:831: const enum print_newline newline) {
>> On 2012/08/24 20:42:03, davidxl wrote:
>>>
>>> '{' goes to the new line.
>>
>>
>> Done.
>>
>>
>> http://codereview.appspot.com/6427063/diff/5001/gcc/gcov-io.h
>> File gcc/gcov-io.h (right):
>>
>> http://codereview.appspot.com/6427063/diff/5001/gcc/gcov-io.h#newcode699
>> gcc/gcov-io.h:699: Used for bookkeeping.  */
>> On 2012/08/24 20:42:03, davidxl wrote:
>>>
>>> typo.
>>
>>
>> Sorry, I don't notice the typo here. This line is copied from
>> load_latency/branch_mispredict_infos.
>>
>>
>> http://codereview.appspot.com/6427063/diff/5001/gcc/gcov-io.h#newcode916
>> gcc/gcov-io.h:916: const enum print_newline);
>> On 2012/08/24 20:42:03, davidxl wrote:
>>>
>>> Fix indentation.
>>
>>
>> Done.
>>
>> http://codereview.appspot.com/6427063/
>
>


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]