This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [patch] PR54146 - rewrite rewrite_into_loop_closed_ssa


Hi,

On Thu, 16 Aug 2012, Steven Bosscher wrote:

> 2. In find_sibling_superloop the first step is to align the loop depth:
>... 
> 3. Now that USE_LOOP and DEF_LOOP are at the same nesting depth,

Ah, that's the crucial point I missed, the while loops starts out with 
loops at the same depth; yes then the loop works.  Thanks for having a 
walk with me :)

> This must meet at some point, because the outermost "loop" of all loops 
> is current_loops->tree_root at depth 0, and we count down from the same 
> loop depth.

Btw, then the comment is still wrong.  You're returning the innermost 
common outer loop, not the outermost (which would be trivial).


Ciao,
Michael.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]