This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] PR target/53633; disable return value warnings for naked functions
- From: "H.J. Lu" <hjl dot tools at gmail dot com>
- To: Sandra Loosemore <sandra at codesourcery dot com>
- Cc: Richard Henderson <rth at redhat dot com>, nick clifton <nickc at redhat dot com>, gcc-patches at gcc dot gnu dot org, "Brook, Paul" <Paul_Brook at mentor dot com>
- Date: Wed, 15 Aug 2012 09:54:38 -0700
- Subject: Re: [PATCH] PR target/53633; disable return value warnings for naked functions
- References: <500D7DE2.7090204@codesourcery.com> <500E8499.4070105@redhat.com> <500F78BF.2070506@codesourcery.com> <50101787.5050502@redhat.com> <501036EC.2040205@codesourcery.com>
On Wed, Jul 25, 2012 at 11:11 AM, Sandra Loosemore
<sandra@codesourcery.com> wrote:
> On 07/25/2012 09:57 AM, Richard Henderson wrote:
>>
>> I'll echo Nick's comments about arm asm in a common test.
>> There's no need to have anything but __asm__(""); there.
>>
>> Ok with that change.
>
> Thanks! Here's the version I committed.
>
> -Sandra
>
>
> 2012-07-25 Sandra Loosemore <sandra@codesourcery.com>
> Paul Brook <paul@codesourcery.com>
>
> PR target/53633
>
> gcc/
> * target.def (warn_func_return): New hook.
> * doc/tm.texi.in (TARGET_WARN_FUNC_RETURN): New hook.
> * doc/tm.texi: Regenerate.
> * doc/sourcebuild.texi (Effective-Target Keywords): Document
> naked_functions.
> * ipa-pure-const.c (warn_function_noreturn): Check
> targetm.warn_func_return.
> * tree-cfg.c (execute_warn_function_return): Likewise.
You didn't mention that you included "target.h" nor add "target.h"
dependency on tree-cfg.c. I am checking in this as an obvious fix.
--
H.J.
--
diff --git a/gcc/Makefile.in b/gcc/Makefile.in
index 65a49d7..f2366ad 100644
--- a/gcc/Makefile.in
+++ b/gcc/Makefile.in
@@ -2363,7 +2363,7 @@ tree-vrp.o : tree-vrp.c $(CONFIG_H) $(SYSTEM_H)
coretypes.h $(TM_H) $(TREE_H) \
$(CFGLOOP_H) $(SCEV_H) intl.h \
$(GIMPLE_PRETTY_PRINT_H) gimple-fold.h $(OPTABS_H) $(EXPR_H)
tree-cfg.o : tree-cfg.c $(TREE_FLOW_H) $(CONFIG_H) $(SYSTEM_H) \
- $(TREE_H) $(TM_P_H) $(GGC_H) $(FLAGS_H) \
+ $(TREE_H) $(TM_P_H) $(GGC_H) $(FLAGS_H) $(TARGET_H) \
$(DIAGNOSTIC_CORE_H) $(FUNCTION_H) $(TM_H) coretypes.h \
$(TREE_DUMP_H) $(EXCEPT_H) $(CFGLOOP_H) $(TREE_PASS_H) \
$(BASIC_BLOCK_H) \