This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, Android] Runtime stack protector enabling for Android target
- From: Igor Zamyatin <izamyatin at gmail dot com>
- To: gcc-patches at gcc dot gnu dot org
- Cc: Uros Bizjak <ubizjak at gmail dot com>, Maxim Kuvyrkov <maxim at codesourcery dot com>
- Date: Wed, 8 Aug 2012 11:54:00 +0400
- Subject: Re: [PATCH, Android] Runtime stack protector enabling for Android target
- References: <CAKdSQZmRs6eBguf=nfKikn4mZPGs4EppbbvfjRNd1GCyM4m8rg@mail.gmail.com> <CA+=Sn1nEaUttz3HZ2Lbs5cXA50hL7J33pEtOk8oQfOa8+HyGzw@mail.gmail.com> <CAKdSQZnGqTPZkFWQSU44Q7YENqaf+8jXKWQWA-4-p+nXS6v8Yw@mail.gmail.com> <CAKdSQZm6v1m5oDhtY2YAyz46ZEoqOqFjhDSJ3i7UK5BT-ayBAg@mail.gmail.com> <C8AD1607-80BA-4C64-993F-D9E5A6F4821B@codesourcery.com> <CAFULd4bUciM1sHTyWhDVVdpKi5mqe-8EDd168k-_AAwnW-JZ7g@mail.gmail.com> <CAKdSQZnFsAuH3Z4KNFqwBVfgo9qvG6WuwKHDm5JQ-q2B5zwzMA@mail.gmail.com> <CAFULd4aFxNH-R9nGXPtKZF-cJ31Ytd0E=L8_fgCrxF=5CY1tLA@mail.gmail.com> <94A68622-D5FE-4436-8012-316DD5AA873B@codesourcery.com>
Hi all!
I'd like to ask whether stack-protector changes for Android could go to 4.7?
Pathes are:
http://gcc.gnu.org/ml/gcc-patches/2012-05/msg01089.html
http://gcc.gnu.org/ml/gcc-patches/2012-07/msg01157.html
Thanks,
Igor
On Wed, Jul 25, 2012 at 2:08 AM, Maxim Kuvyrkov <maxim@codesourcery.com> wrote:
> On 24/07/2012, at 10:08 PM, Uros Bizjak wrote:
>
>> On Mon, Jul 23, 2012 at 10:00 PM, Igor Zamyatin <izamyatin@gmail.com> wrote:
>>
>>> 2012-07-23 Sergey Melnikov <sergey.melnikov@intel.com>
>>>
>>> * config/i386/i386.md (stack_protect_set): Disable the pattern
>>> for Android since Android libc (bionic) does not provide random
>>> value for stack protection guard at gs:0x14. Guard value
>>> will be provided from external symbol (default implementation).
>>> (stack_protect_set_<mode>): Likewise.
>>> (stack_protect_test): Likewise.
>>> (stack_protect_test_<mode>): Likewise.
>>> * gcc/defaults.h: Define macro TARGET_HAS_BIONIC to 0 - target does
>>> not have Bionic by default
>>> * config/linux.h: Redefine macro TARGET_HAS_BIONIC to (OPTION_BIONIC)
>>> Macro OPTION_BIONIC is defined in this file and provides Bionic
>>> accessibility status
>>
>> Looks OK to me, patch needs approval from Maxim.
>
> OK. Thanks for fixing this.
>
> --
> Maxim Kuvyrkov
> CodeSourcery / Mentor Graphics
>