This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH] Fix comment in cgraphunit.c
- From: Richard Guenther <richard dot guenther at gmail dot com>
- To: Marek Polacek <polacek at redhat dot com>
- Cc: GCC Patches <gcc-patches at gcc dot gnu dot org>
- Date: Wed, 25 Jul 2012 13:43:59 +0200
- Subject: Re: [PATCH] Fix comment in cgraphunit.c
- References: <20120713120054.GC3468@redhat.com> <20120724192727.GA3311@redhat.com>
On Tue, Jul 24, 2012 at 9:27 PM, Marek Polacek <polacek@redhat.com> wrote:
> Ping.
Ok.
Thanks,
Richard.
> On Fri, Jul 13, 2012 at 02:00:54PM +0200, Marek Polacek wrote:
>> I think the comment at the start of the file is wrong, since
>> it speaks about varpool_finalize_variable, but there's no such
>> function (not even mentioned in CLs). I'd say the author meant
>> varpool_finalize_decl.
>>
>> 2012-07-13 Marek Polacek <polacek@redhat.com>
>>
>> * cgraphunit.c: Rename varpool_finalize_variable to
>> varpool_finalize_decl in a comment.
>>
>> --- gcc/cgraphunit.c.mp 2012-07-13 13:49:41.071591575 +0200
>> +++ gcc/cgraphunit.c 2012-07-13 13:49:50.715613502 +0200
>> @@ -34,7 +34,7 @@ along with GCC; see the file COPYING3.
>> (There is one exception needed for implementing GCC extern inline
>> function.)
>>
>> - - varpool_finalize_variable
>> + - varpool_finalize_decl
>>
>> This function has same behavior as the above but is used for static
>> variables.
>>
>> Marek