This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, ARM] Skip gcc.dg/torture/stackalign/builtin-apply-2.c for ARM hard-float ABI
- From: Richard Earnshaw <rearnsha at arm dot com>
- To: Julian Brown <julian at codesourcery dot com>
- Cc: "gcc-patches at gcc dot gnu dot org" <gcc-patches at gcc dot gnu dot org>, "ramana dot radhakrishnan at linaro dot org" <ramana dot radhakrishnan at linaro dot org>
- Date: Mon, 23 Jul 2012 14:40:59 +0100
- Subject: Re: [PATCH, ARM] Skip gcc.dg/torture/stackalign/builtin-apply-2.c for ARM hard-float ABI
- References: <20120723131706.1c0af756@octopus>
On 23/07/12 13:17, Julian Brown wrote:
> Hi,
>
> The test case gcc.dg/torture/stackalign/builtin-apply-2.c makes
> assumptions which cannot be met for __builtin_apply for the ARM
> hard-float ABI variant. This patch simply skips the test in that case.
>
> Tested (stackalign.exp only) for ARMv4t -marm/-mthumb/-mfloat-abi=hard.
> The previously-failing test gets skipped as expected with the patch.
> (This is another one that we've had locally for a while.)
>
> OK to apply?
>
> Julian
>
> ChangeLog
>
> gcc/testsuite/
> * gcc.dg/torture/stackalign/builtin-apply-2.c: Skip for
> hard-float ARM.
>
>
> skip-builtin-apply-2-for-hardfloat-arm-2.diff
>
Hmm, I think this won't work for platforms like fedora/arm, where
-mfloat-abi=hard is the default.
R.
>
> Index: gcc/testsuite/gcc.dg/torture/stackalign/builtin-apply-2.c
> ===================================================================
> --- gcc/testsuite/gcc.dg/torture/stackalign/builtin-apply-2.c (revision 189779)
> +++ gcc/testsuite/gcc.dg/torture/stackalign/builtin-apply-2.c (working copy)
> @@ -5,6 +5,8 @@
> with pre-pushed arguments (e.g. SPARC). */
>
> /* { dg-do run } */
> +
> +/* { dg-skip-if "Variadic funcs use Base AAPCS. Normal funcs use VFP variant." { "arm*-*-*" } { "-mfloat-abi=hard" } { "" } } */
>
>
> #define INTEGER_ARG 5
>