This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: Updated to respond to various email comments from Jason, Diego and Cary (issue6197069)
- From: Sterling Augustine <saugustine at google dot com>
- To: Dominique Dhumieres <dominiq at lps dot ens dot fr>
- Cc: gcc-patches at gcc dot gnu dot org, jason at redhat dot com, ccoutant at google dot com
- Date: Fri, 22 Jun 2012 09:45:35 -0700
- Subject: Re: Updated to respond to various email comments from Jason, Diego and Cary (issue6197069)
- References: <20120622094701.666F03BE19@mailhost.lps.ens.fr>
On Fri, Jun 22, 2012 at 2:47 AM, Dominique Dhumieres <dominiq@lps.ens.fr> wrote:
>> I've heard reports of new test failures due to this patch:
>>
>> FAIL: gcc.dg/pubtypes-2.c scan-assembler long+[ \\t]+0x6a+[ \\t]+[#;]+[ \\t]+Length of Public Type Names Info
>> FAIL: gcc.dg/pubtypes-3.c scan-assembler long+[ \\t]+0x6a+[ \\t]+[#;]+[ \\t]+Length of Public Type Names Info
>> FAIL: gcc.dg/pubtypes-4.c scan-assembler long+[ \\t]+0xa1+[ \\t]+[#;]+[ \\t]+Length of Public Type Names Info
>> ...
>> For the first group, you probably just need to update the test. ...
>
> Since it is a darwin only test, the new numbers are
>
> [macbook] f90/bug% gcc48 -S -O0 -gdwarf-2 -dA /opt/gcc/work/gcc/testsuite/gcc.dg/pubtypes-2.c
> [macbook] f90/bug% grep "Length of Public Type Names Info" pubtypes-2.s
> ? ? ? ?.long ? 0x13b ? # Length of Public Type Names Info
> [macbook] f90/bug% gcc48 -S -O0 -gdwarf-2 -dA /opt/gcc/work/gcc/testsuite/gcc.dg/pubtypes-3.c
> [macbook] f90/bug% grep "Length of Public Type Names Info" pubtypes-2.s
> ? ? ? ?.long ? 0x13b ? # Length of Public Type Names Info
> [macbook] f90/bug% gcc48 -S -O0 -gdwarf-2 -dA /opt/gcc/work/gcc/testsuite/gcc.dg/pubtypes-4.c
> [macbook] f90/bug% grep "Length of Public Type Names Info" pubtypes-4.s
> ? ? ? ?.long ? 0x172 ? # Length of Public Type Names Info
>
> Is the increase in size expected?
Yes. The new edition of pubnames are much more complete than the old
ones. Enumerators being just one example of something that wasn't
included before that is now. There are several others, including more
complete collection of scopes and anonymous namespaces.
Sterling