This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.

Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH 2/3] Use synth_mult for vector multiplies vs scalar constant

On 2012-06-16 04:19, Eric Botcazou wrote:
>> @@ -179,7 +179,11 @@ extern const unsigned char
>> mode_class[NUM_MACHINE_MODES];
>>
>>  extern CONST_MODE_SIZE unsigned char mode_size[NUM_MACHINE_MODES];
>>  #define GET_MODE_SIZE(MODE)    ((unsigned short) mode_size[MODE])
>> -#define GET_MODE_BITSIZE(MODE) ((unsigned short) (GET_MODE_SIZE (MODE) *
>> BITS_PER_UNIT)) +
>> +#define GET_MODE_BITSIZE(MODE) \
>> +  ((unsigned short) (GET_MODE_SIZE (MODE) * BITS_PER_UNIT))
>> +#define GET_MODE_UNIT_BITSIZE(MODE) \
>> +  ((unsigned short) (GET_MODE_UNIT_SIZE (MODE) * BITS_PER_UNIT))
>>
>>  /* Get the number of value bits of an object of mode MODE.  */
>>  extern const unsigned short mode_precision[NUM_MACHINE_MODES];
> 
> Can you move GET_MODE_UNIT_BITSIZE to after GET_MODE_UNIT_SIZE, changing "size 
> in bytes" to "size in bytes and bits" in the comment just above?  Because the 
> overloading of UNIT in the macro makes the whole thing slightly confusing. :-)
> 

Done in the committed patch.


r~
Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]