This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, gdc] - Merging gdc (GNU D Compiler) into gcc
- From: "Joseph S. Myers" <joseph at codesourcery dot com>
- To: Iain Buclaw <ibuclaw at ubuntu dot com>
- Cc: gcc-patches at gcc dot gnu dot org
- Date: Tue, 19 Jun 2012 16:33:52 +0000 (UTC)
- Subject: Re: [PATCH, gdc] - Merging gdc (GNU D Compiler) into gcc
- References: <CABOHX+fQctbUkJcH1-CX_5j8-fW3Lh3iuquvGrEGGd3vEM0Zvw@mail.gmail.com>
On Mon, 18 Jun 2012, Iain Buclaw wrote:
> http://www.gdcproject.org/files/gdc_libphobos.patch.gz
Same comments as before about FSF postal addresses.
Although runtime libraries need not be assigned to the FSF (as per the GCC
Mission Statement), all significant files should still have copyright and
license notices (approved by all significant contributors) so that people
know the free software terms under which they may be used. E.g.,
libphobos/libdruntime/config/x3.c appears to be missing such notices.
Without a license (or a dedication to the public domain), a file is
presumptively copyright and has no license for anyone to use it at all.
> +if true; then
"if true" seems odd; if you have a good reason for it, you need to comment
it.
> +# generated automatically by aclocal 1.9.6 -*- Autoconf -*-
Please use the standard documented autoconf/automake versions for GCC
(autoconf 2.64, automake 1.11.1).
> diff -Naur gcc-4.8-20120617/libphobos/autom4te.cache/output.0 gcc-4.8/libphobos/autom4te.cache/output.0
We don't check in autom4te.cache directories.
> +# libphobos is usually a symlink to gcc/d/phobos, so libphobos/..
No it's not. No runtime libraries should go under gcc/ any more at all.
> +dnl Copied from libstdc++-v3/acinclude.m4. Indeed, multilib will not work
Refactor into the config/ directory, don't copy.
> \ No newline at end of file
Add any missing newlines to text files in all patches.
--
Joseph S. Myers
joseph@codesourcery.com