This is the mail archive of the
gcc-patches@gcc.gnu.org
mailing list for the GCC project.
Re: [PATCH, libcpp]: Use x86 __builtin_ia32_pcmpestri128 instead of asm.
On 2012-06-18 23:38, Uros Bizjak wrote:
> On Tue, Jun 19, 2012 at 12:07 AM, Richard Henderson <rth@redhat.com> wrote:
>> On 2012-06-18 13:19, Uros Bizjak wrote:
>>> /* ??? The builtin doesn't understand that the PCMPESTRI read from
>>> memory need not be aligned. */
>>> - __asm ("%vpcmpestri $0, (%1), %2"
>>> - : "=c"(index) : "r"(s), "x"(search), "a"(4), "d"(16));
>>> + sv = __builtin_ia32_loaddqu ((const char *) s);
>>> + index = __builtin_ia32_pcmpestri128 (search, 4, sv, 16, 0);
>>> +
>>
>>
>> Surely the comment can be removed too then?
>
> I'm not sure there. The builtin, as defined, expects V16QI operand
> with xm constraint.
Fair enough. I'm ok with the patch as-is.
r~