This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [PATCH] Fix part of PR30442


On Tue, 5 Jun 2012, Richard Guenther wrote:

> On Tue, 5 Jun 2012, Nathan Froyd wrote:
> 
> > On Tue, Jun 05, 2012 at 02:35:30PM +0200, Richard Guenther wrote:
> > > Index: gcc/tree-vect-data-refs.c
> > > ! 	  gimple stmt = gsi_stmt (gsi);
> > > ! 	  if (!find_data_references_in_stmt (NULL, stmt,
> > > ! 					     &BB_VINFO_DATAREFS (bb_vinfo)))
> > > ! 	    {
> > > ! 	      /* Mark the rest of the basic-block as unvectorizable.  */
> > > ! 	      for (; !gsi_end_p (gsi); gsi_next (&gsi))
> > 
> > I see iteration through the rest of the basic block...
> > 
> > > ! 		STMT_VINFO_VECTORIZABLE (vinfo_for_stmt (stmt)) = false;
> > 
> > ...but I don't see corresponding updates to stmt.
> 
> Eh ...
> 
> fix in testing.

Tested on x86_64-unknown-linxu-gnu, applied.

Richard.

2012-06-05  Richard Guenther  <rguenther@suse.de>

	* tree-vect-data-refs.c (vect_analyze_data_refs): Fix last
	change.

Index: gcc/tree-vect-data-refs.c
===================================================================
--- gcc/tree-vect-data-refs.c	(revision 188235)
+++ gcc/tree-vect-data-refs.c	(working copy)
@@ -2855,7 +2855,10 @@ vect_analyze_data_refs (loop_vec_info lo
 	    {
 	      /* Mark the rest of the basic-block as unvectorizable.  */
 	      for (; !gsi_end_p (gsi); gsi_next (&gsi))
-		STMT_VINFO_VECTORIZABLE (vinfo_for_stmt (stmt)) = false;
+		{
+		  stmt = gsi_stmt (gsi);
+		  STMT_VINFO_VECTORIZABLE (vinfo_for_stmt (stmt)) = false;
+		}
 	      break;
 	    }
 	}


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]