This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [cxx-conversion] New Hash Table (issue6244048)


On Friday 25 of May 2012 10:15:54 Diego Novillo wrote:
> On 12-05-25 09:56 , Jakub Jelinek wrote:
> > On Fri, May 25, 2012 at 03:51:25PM +0200, Michael Matz wrote:
> >> On Fri, 25 May 2012, Gabriel Dos Reis wrote:
> >> That's one of my fears, namely that those used to the libstdc++ style
> >> impose that on the compiler source base.  Because IMHO the libstdc++ style
> >> isn't very appealing.
> >
> > Seconded.
> 
> I don't care how ugly coding conventions look.  I've dealt with many and 
> they all have their ugly spots.  I mostly care about consistency.
> 
> I don't think we should deviate much from the established GNU standards 
> (which are hideous, btw).  Mostly because we are all used to them and it 
> is going to be simpler to write new code that is similar to what is 
> already there.
> 
> Lawrence, Ian and Gaby have been working on the proposed coding 
> guidelines for C++ (http://gcc.gnu.org/wiki/CppConventions).

on this page we can read:

"The following features of the C++ language should in general be avoided in GCC code.
 (...)
 Defining new templates (use of existing templates, e.g., from the standard library, is fine)."

so, why you just don't use the hash table implementation from libstdc++?

BR,
PaweÅ.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]