This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: PATCH: PR target/53425: No warnings are given for -mno-sse


On Sun, May 20, 2012 at 4:15 PM, H.J. Lu <hongjiu.lu@intel.com> wrote:

> We should warn passing SSE vector argument without SSE enabled changes
> the ABI for 64-bit. Tested on Linux/x86-64. ?OK to install?
>
> 2012-05-20 ?H.J. Lu ?<hongjiu.lu@intel.com>
>
> ? ? ? ?PR target/53425
> ? ? ? ?* config/i386/i386.c (type_natural_mode): Warn passing SSE
> ? ? ? ?vector argument without SSE enabled changes the ABI.
>
> gcc/testsuite/
>
> 2012-05-20 ?H.J. Lu ?<hongjiu.lu@intel.com>
>
> ? ? ? ?PR target/53425
> ? ? ? ?* gcc.target/i386/pr53425.c: New file.
>
> diff --git a/gcc/config/i386/i386.c b/gcc/config/i386/i386.c
> index eca542c..a56847a 100644
> --- a/gcc/config/i386/i386.c
> +++ b/gcc/config/i386/i386.c
> @@ -5828,7 +5833,22 @@ type_natural_mode (const_tree type, const CUMULATIVE_ARGS *cum)
> ? ? ? ? ? ? ? ? ? ?return TYPE_MODE (type);
> ? ? ? ? ? ? ? ? ?}
> ? ? ? ? ? ? ? ?else
> - ? ? ? ? ? ? ? ? return mode;
> + ? ? ? ? ? ? ? ? {

No need for these outermost braces.

BTW: Can you please also add MMX warning for -mno-mmx to be consistent
with 32bit targets?

OK with these changes.

Thanks,
Uros.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]