This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [google/google-main] Fix regression - SUBTARGET_EXTRA_SPECS overridden by LINUX_GRTE_EXTRA_SPECS (issue 6016047)


I suspect this patch would change specs of non-i386 platform. For
example, LINUX_GRTE_EXTRA_SPECS is not part of SUBTARGET_EXTRA_SPECS for
darwin.

Can you tell where SUBTARGET_EXTRA_SPECS is firstly defined for chromeos
toolchain?



On 2012/05/14 18:32:17, shenhan wrote:
On 2012/04/12 21:14:29, shenhan wrote:
> Hi, the newest chrome gcc (from google-main) fails to linking
anything, by
> looking into specs file, it seems that 'link_emulation' section is
missing in
> specs.
>
> The problem I found is that SUBTARGET_EXTRA_SPECS, which is not
empty for
> chromeos, is overridden by "LINUX_GRTE_EXTRA_SPECS".
>
> Please review the proposed a patch. (Tested by buildit bootstrap).
>
> -Han

Hi Jing and Rong, could you take a look at this?

Thanks,
-Han



http://codereview.appspot.com/6016047/



Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]