This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [Patch / RFC] Improving more locations for binary expressions


On 05/10/2012 04:28 PM, Jason Merrill wrote:
Looks good.
Thanks Jason. The below is the idea fully implemented.

The call.c bits are exactly in the form I had in mind a couple of days ago.

The parser.c bits, the ones I actually preliminarily posted, are now a bit different: I noticed that in the middle of the function we were reading / writing all the cp_parser_expression_stack_entry fields by hand (and now would be one more) thus tweaked the algorithm to use a cp_parser_expression_stack_entry as local variable. In my opinion this tidies the code quite a bit and also makes manifest that tree_type and loc are always updated at the same time, as they should be.

Booted and tested x86_64-linux. Ok?

Thanks,
Paolo.

//////////////////////////////

Attachment: CL_binary_expression_location
Description: Text document

Attachment: patch_binary_expression_location
Description: Text document


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]