This is the mail archive of the gcc-patches@gcc.gnu.org mailing list for the GCC project.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]
Other format: [Raw text]

Re: [testsuite] Fix gcc.target/i386/hle-* testcases with Sun as


On Wed, May 9, 2012 at 12:53 PM, Rainer Orth
<ro@cebitec.uni-bielefeld.de> wrote:

>>> Several /gcc.target/i386/hle-*.c tests are currently failing on Solaris
>>> 9/x86 with Sun as:
>>>
>>> FAIL: gcc.target/i386/hle-add-acq-1.c scan-assembler lock[ \\n\\t]+(xacquire|.byte[ \\t]+0xf2)[ \\t\\n]+add
>>>
>>> The .s file has
>>>
>>> ? ? ? ?lock;
>>> ? ? ? ?.byte ? 0xf2
>>>
>>> but the scan-assembler regex currently doesn't allow for the ; (which is
>>> not present with gas 2.22).
>>>
>>> The patch below does just that. ?Tested with the appropriate runtest
>>> invocation on i386-pc-solaris2.9 configured with as and gas
>>> respectively.
>>>
>>> Ok for mainline?
>>
>> Ok, assuming that the ; has to be there. ?If it doesn't have to be
>
> I just rechecked: this is covered by the gcc_cv_as_ix86_rep_lock_prefix
> test in gcc/configure.as which fails with the Solaris (8 and) 9 native
> assembler.
>
>> there, an alternative patch might be to remove it from the port now
>> instead of the patch.
>
> Right, that's why I was asking for review rather than just installing on
> my own.

I'd rather see that we remove semicolon in this case, but please note
that xchg with memory operand doesn't need lock prefix. If it is not
too much trouble...

Uros.


Index Nav: [Date Index] [Subject Index] [Author Index] [Thread Index]
Message Nav: [Date Prev] [Date Next] [Thread Prev] [Thread Next]